Remove JIT log file #972
Merged
Remove JIT log file #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now comments can be added by the jit and still end up in the spesh log. Currently it outputs what instructions bail the jit, which end the exprjit compiler in the middle of a BB, what repr ops get devirtualized or not.
which is almost exclusively "begin of exprjit" comments, but still.
So that we may profile (on linux) and have insight on the time spent on JIT-compiled frames. Not sure if it will give good results, because we don't always compile with -fno-omit-frame-pointer.
No need to have a separate JIT log, if we can attach messages to the spesh debug log.
No longer necessary in jit log now that spesh graph comments exist
DynASM not being able to link is a JIT compiler error. JIT unable to get rx pages is a configuration error (at the best of times). Both warrant some level of noise.
We don't support it, don't need it (yet), so remove dead code
Now that we have most useful JIT information in the spesh log, we can remove the noise from the JIT log that just replicates that.
If MVM_JIT_DEBUG is enabled, JIT specific (structured) debugging information will be logged in the spesh log.
This is easier for the developer because tile log and expression tree are close together.
No need to specify the exact bytecode directory, if we can put it in a consistent place anyway.
|
So, how would one find out which blocks are not getting JITted? |
|
@lizmat The information is now folded into the specialization log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new spesh graph comments, let's get rid of the adhoc JIT log.