Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Better handling of info.plist files in IOS Source #1241

Closed
Nicoolai opened this issue Jan 27, 2020 · 2 comments
Closed

[FEATURE] Better handling of info.plist files in IOS Source #1241

Nicoolai opened this issue Jan 27, 2020 · 2 comments
Assignees
Labels
enhancement MobSF enhancements and feature requests

Comments

@Nicoolai
Copy link
Contributor

If you're requesting a new feature/enhancement, explain why you'd like it to be added and it's importance.

Is your feature request related to a problem? Please describe.
When working with large IOS projects, it is not uncommon, at least in our org, that projects are structured into modules.
Each module has their own info.plist. This causes some problems with mobSF as it appears to simply pick the first info.plist if finds (when scanning IOS Source, it is not an issue in binary as all the plist's are combined into one), which could easily be a sub-module instead of the actual app.

Furthermore, you are free to name the info.plist file as you please. It does not have to be called info.plist.

I would like to hear some opinions on how to solve this and if it even should be solved. Maybe we're the only ones with this issue?

Describe the solution you'd like
Perhaps we could have an optional parameter, in the scan api call, with the name of the configuration that gets built. That way, it could check the project.pbxproj file, and find that configuration.
In the configuration, in the project file, it shows the path the info.plist file and also values that you might replace, in it, using variable placeholders.
Combining these two things could potentially give you the proper info.plist content.

Describe alternatives you've considered
N/A

Additional context
N/A

@Nicoolai Nicoolai added the enhancement MobSF enhancements and feature requests label Jan 27, 2020
@Nicoolai
Copy link
Contributor Author

I haven't really been able to come up with any good solutions for this, so I am giving up.
Instead, I will change our process and include the binary in the source and simply extract the final info.plist from binary and do the rest of the analysis on src.

@ajinabraham
Copy link
Member

Tracked separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MobSF enhancements and feature requests
Projects
None yet
Development

No branches or pull requests

2 participants