Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Provide codes for simplified classification of issues #1356

Closed
ghost opened this issue Apr 14, 2020 · 1 comment
Closed

[FEATURE] Provide codes for simplified classification of issues #1356

ghost opened this issue Apr 14, 2020 · 1 comment
Assignees
Labels
enhancement MobSF enhancements and feature requests

Comments

@ghost
Copy link

ghost commented Apr 14, 2020

The JSON reporting API should be extended so that parsing to distinguish different issues is no longer necessary. Introducing such issue codes would greatly simplify machine processing.

Examples:

  • iOS App Transport Security (ATS) issues:
    I suggest issue codes based on the triggered expression.
    • Insecure communication to xxx.xxx.xxx is allowed -> Either NSTemporaryExceptionAllowsInsecureHTTPLoads or NSExceptionAllowsInsecureHTTPLoads
    • NSIncludesSubdomains set to TRUE for xxx.xxx.xxx -> NSIncludesSubdomainsAllowed
    • NSExceptionMinimumTLSVersion set to TLSv1.1 on xxx.xxx.xxx -> NSExceptionMinimumTLSVersion11
    • ...

Issues in other sections do not contain contextual information (or provide a field like name in the Android manifest analysis) afaik. However, it is desirable to use a one-word code instead of a sentence - the former is imho less likely to be edited.

Example:
The issue c_prot_normal_new of the Android manifest analysis contains context-dependent information in the title; the name is suitable for distinguishing it from other issues but is also very long:
is Protected by a permission, but the protection level of the permission should be checked if the application runs on a device where the the API level is less than 17 [Content Provider, targetSdkVersion >= 17].

@ghost ghost added the enhancement MobSF enhancements and feature requests label Apr 14, 2020
@ghost ghost assigned ajinabraham Apr 14, 2020
@ajinabraham
Copy link
Member

Tracked Separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MobSF enhancements and feature requests
Projects
None yet
Development

No branches or pull requests

1 participant