Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of ability to View Source in browser in some cases until upstream EnlighterJS bug is fixed #1603

Closed
nuschpl opened this issue Nov 24, 2020 · 4 comments
Labels
enhancement MobSF enhancements and feature requests

Comments

@nuschpl
Copy link

nuschpl commented Nov 24, 2020

EnlighterJS/EnlighterJS#144

@nuschpl nuschpl changed the title Lack of ability to View Source in browser until upstream bug is fixed Lack of ability to View Source in browser in some cases until upstream EnlighterJS bug is fixed Nov 24, 2020
@ajinabraham ajinabraham added the enhancement MobSF enhancements and feature requests label Dec 4, 2020
@ajinabraham
Copy link
Member

Waiting for upstream to cut a release. Tracked separately.

@nuschpl
Copy link
Author

nuschpl commented Dec 4, 2020

I doubt it's 'enhancment' I would call it regression as this used to work and now you can't use basic functionality due to fact syntax is colored. Can't we just revert this to work as before untill upstream fix ?

@ajinabraham
Copy link
Member

This is out of our control, we switched to this library for the support of line numbers which the previous library has no support for. As it stands the maintainer of EnlighterJS has to release a fix or we are open to PR that could fix the issues while still providing all the existing features.

@anantshri
Copy link
Contributor

faced this today.
mid way could be if enlighterjs error is detected then text is presented without the highlight. so usual smaller files work as is. any large file atleast gets listed minus all the funky bits. but i can understand in case @ajinabraham would like to wait for the upstream to fix it as it would probably only affect a small number of people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MobSF enhancements and feature requests
Projects
None yet
Development

No branches or pull requests

3 participants