Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Find API keys/secrets by matching regex #1843

Closed
sdushantha opened this issue Nov 16, 2021 · 3 comments
Closed

[FEATURE] Find API keys/secrets by matching regex #1843

sdushantha opened this issue Nov 16, 2021 · 3 comments
Assignees
Labels
enhancement MobSF enhancements and feature requests

Comments

@sdushantha
Copy link

sdushantha commented Nov 16, 2021

If you're requesting a new feature/enhancement, explain why you'd like it to be added and it's importance.

We currently have a feature which find possible hardcoded secrets. But there could be false positives. So I am suggesting a feature which will use regex to find API keys. I currently have a command line program called dora which does exactly this. But would of course be very nice if this was implemented into this program so we'd get exact matches to those API keys/secrets.

Is your feature request related to a problem? Please describe.
It is not a problem.

Describe the solution you'd like
Use a list of regex that match certain API keys/secrets so they will be found without any false positives. I am willing to provide the regex patterns if needed.

Describe alternatives you've considered
I currently use my program called dora but if MobSF had this inbuilt, it would be ease my workflow.

@sdushantha sdushantha added the enhancement MobSF enhancements and feature requests label Nov 16, 2021
@github-actions
Copy link

👋 @sdushantha
Issues is only for reporting a bug/feature request. For limited support, questions, and discussions, please join MobSF Slack channel
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@ajinabraham
Copy link
Member

ajinabraham commented Nov 27, 2021

The reason why we didn't go with the regex approach is that it will miss a lot of possible secrets as the regexes are fairly specific.

@ajinabraham
Copy link
Member

Closing this and tracking this separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MobSF enhancements and feature requests
Projects
None yet
Development

No branches or pull requests

2 participants