Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Enhancing secret detection with regex rules #2191

Closed
ksg97031 opened this issue Jun 20, 2023 · 3 comments
Closed

[FEATURE] Enhancing secret detection with regex rules #2191

ksg97031 opened this issue Jun 20, 2023 · 3 comments
Assignees
Labels
enhancement MobSF enhancements and feature requests

Comments

@ksg97031
Copy link

Hello,

I believe that simply searching for keywords like 'api' or 'key' is insufficient when trying to �detect a secret. Have you considered using regular expression rules to detect secret patterns?

As you are already know, it's quite simple to find an example demonstrating the implementation of this approach.
https://github.com/dwisiswant0/apkleaks/blob/master/config/regexes.json

@ksg97031 ksg97031 added the enhancement MobSF enhancements and feature requests label Jun 20, 2023
@github-actions
Copy link

👋 @ksg97031
Issues is only for reporting a bug/feature request. For limited support, questions, and discussions, please join MobSF Slack channel
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@ohyeah521
Copy link
Contributor

Regularity is indeed a good strategy, but it will increase system overhead. If the apk file is large and a single smali file exceeds 5m, the matching speed will be extremely slow

@ajinabraham
Copy link
Member

Tracked separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement MobSF enhancements and feature requests
Projects
None yet
Development

No branches or pull requests

3 participants