Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for <stripArchives> (RoboVM 1.11) #45

Closed
StefanOltmann opened this issue Sep 19, 2016 · 6 comments
Closed

Support for <stripArchives> (RoboVM 1.11) #45

StefanOltmann opened this issue Sep 19, 2016 · 6 comments

Comments

@StefanOltmann
Copy link

StefanOltmann commented Sep 19, 2016

Please implement support for the 'stripArchives' tag in robovm.xml:
http://docs.robovm.com/configuration.html#striparchives

https://groups.google.com/forum/#!topic/robovm/fE_ixkLIuCc

I think this feature is mission critical for most apps as many libs come
with unnecessary ressources and this option decreased the app size.

@florianf
Copy link
Collaborator

Hi Stefan,
thanks for the report. This would be rather straight forward to implement, do you want to give it a try?

The method for stripping jars is located here:
https://github.com/MobiDevelop/robovm/blob/master/compiler/compiler/src/main/java/org/robovm/compiler/target/AbstractTarget.java#L514

The Config class to which the robovm.xml is mapped is located here:
https://github.com/MobiDevelop/robovm/blob/master/compiler/compiler/src/main/java/org/robovm/compiler/config/Config.java

You would need the necessary props to the Config class and implement the filter logic in the stripArchive method.
If you need any further assistance, drop a line or head over to our Gitter channel.

@StefanOltmann
Copy link
Author

Yes, I want to give it a try. :-)

@florianf
Copy link
Collaborator

Great, just ask if you need some help.

@kirillp
Copy link

kirillp commented Sep 27, 2016

please add .java to default strip list

@StefanOltmann
Copy link
Author

I created a pull request #56 for a implementation that works pretty well for me. But there may be room for improvement with the regex replaces.

@StefanOltmann
Copy link
Author

Can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants