Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action to build Android release #3

Merged

Conversation

gardner
Copy link

@gardner gardner commented Oct 20, 2023

Not sure if you want to incorporate this yet but I hope it helps to get some CI going. It takes about 10-15 minutes per build which could probably be improved with some caching.

@danemadsen
Copy link
Member

lgtm

@danemadsen danemadsen merged commit a289ffb into Mobile-Artificial-Intelligence:main Oct 20, 2023
@danemadsen
Copy link
Member

Any ideas why the action is failing? I setup the key how you said in the readme?

@gardner
Copy link
Author

gardner commented Oct 20, 2023

Just a heads up. It requires some configuration that is described in the README.

You can use a throwaway key until you are ready to publish to the Play Store. People will be able to side-load it.

It still requires a "publish on new tag". Right now it just uploads the APK as an artifact to the GitHub Actions build page. I don't think they are public unless they are explicitly published.

I'll see if I can get "publish on new tag" working and submit a PR.

@gardner
Copy link
Author

gardner commented Oct 20, 2023

Maybe there was a trailing space on one of the strings added in secrets? You could try setting the values again.

You can see the values being masked with *** in the Create key.properties step. So it seems like the names are correct.

* What went wrong:
Execution failed for task ':app:packageRelease'.
> A failure occurred while executing com.android.build.gradle.tasks.PackageAndroidArtifact$IncrementalSplitterRunnable
   > com.android.ide.common.signing.KeytoolException: Failed to read key *** from store "/home/runner/work/maid/maid/android/app/key.jks": Get Key failed: Given final block not properly padded. Such issues can arise if a bad key is used during decryption.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants