CADT HTTP server doesn't work on Android < KK

[clelland]

The HTTP server breaks on older Android versions because of a missing ArrayBuffer.prototype.slice method. We'll need to polyfill that, or to use a different method in the HttpServer.js code.

[clelland]

Fixed with 5fcc666

[cyberflohr]

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 6, col 15, Strings must use singlequote.
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js: line 9, col 15, Unexpected use of '|'.

2 errors
[15:39:35] 'lint:app' errored after 473 ms

[agrieve]

Thanks for pointing this out. Just pushed a fix (moved the file into libs/
so as to be ignored by the linter)

On Fri, Jul 11, 2014 at 9:52 AM, Wolfgang Flohr-Hochbichler <
notifications@github.com> wrote:

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js:
line 6, col 15, Strings must use singlequote.
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js:
line 9, col 15, Unexpected use of '|'.

2 errors
[15:39:35] 'lint:app' errored after 473 ms

—
Reply to this email directly or view it on GitHub
#22 (comment)
.

[agrieve]

this is now included in the 0.8.1 release!

On Fri, Jul 11, 2014 at 12:30 PM, Andrew Grieve agrieve@chromium.org
wrote:

Thanks for pointing this out. Just pushed a fix (moved the file into libs/
so as to be ignored by the linter)

On Fri, Jul 11, 2014 at 9:52 AM, Wolfgang Flohr-Hochbichler <
notifications@github.com> wrote:

the above fix will raise the following lint errors during build

[15:39:35] Finished 'lint:harness-push' after 209 ms
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js:
line 6, col 15, Strings must use singlequote.
/Projects/ChromeApps/chrome-app-developer-tool/www/cdvah/js/polyfill/slice.js:
line 9, col 15, Unexpected use of '|'.

2 errors
[15:39:35] 'lint:app' errored after 473 ms

—
Reply to this email directly or view it on GitHub
#22 (comment)
.

[cyberflohr]

just tested 0.8.1, works like a charm - thank you! :-)