Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Change Crosswalk Version? #23

Closed
svox1 opened this issue Apr 19, 2015 · 11 comments
Closed

Change Crosswalk Version? #23

svox1 opened this issue Apr 19, 2015 · 11 comments

Comments

@svox1
Copy link

svox1 commented Apr 19, 2015

Hi,
thanks for this great plugin.

I use crosswalk for a while and test now your integration.
After playing around I ask me, how to change the Crosswalk version? I wanna use:
12.41.296.9
Is it possible to change this version for myself?

Regards

@tanasebutcaru
Copy link

Changing 11+ with 12+ in this file libs/xwalk_core_library/xwalk.gradle should do the trick. (didn't tried it)
Also you can check the repo here https://download.01.org/crosswalk/releases/crosswalk/android/maven2/org/xwalk/ ...from what I can see/understand from the repo & xwalk.gradle file, the cordova-plugin-crosswalk-webview installs a beta version of the library, why?

Edit: Tested & working! :)
Just download the 1.0.0 release, unzip and edit the xwalk.gradle file and add the plugin via cordova plugin add <path-to-crosswalk-dir> and that's all.
-- or --
Install the plugin normally and navigate to /platforms/android/cordova-plugin-crosswalk-webview/, open projectName-xwalk.gradle file and change the version and on cordova build/run/emulate the desired version will be used.

Still, question for devs: why do we use the beta library? I thought that it's only for -dev, but after downloading 1.0.0 release I saw that is the same.

@svox1
Copy link
Author

svox1 commented Apr 21, 2015

Thanks for the hint!

@svox1 svox1 closed this as completed Apr 21, 2015
@agrieve
Copy link

agrieve commented Apr 21, 2015

FYI - just published a new version (v1.1.0) that sets the default version to crosswalk 13, and that makes the crosswalk version configurable via a <preference> (refer to README.md)

@Bnaya
Copy link

Bnaya commented Apr 21, 2015

I've opened a feature request to crosswalk to made also canary version available
https://crosswalk-project.org/jira/browse/XWALK-3986
Vote it up please :)

I made that comment on the wrong issue, that should be #24

@svox1
Copy link
Author

svox1 commented Apr 21, 2015

@agrieve
Thats great! Thx!

@hirbod
Copy link

hirbod commented Apr 21, 2015

Seems like we had the same idea. See #24 and https://crosswalk-project.org/jira/browse/XWALK-3987

@tanasebutcaru
Copy link

My question about xwalk library version is still up!
To make it clear: the production ready version is the stable one that can be found here (11.x), right?
So, if someone installs this plugin and immediately runs cordova build android, then the app will use the latest beta version of the crosswalk webview (which is 13 in 1.1.0).

I think that the plugin releases should use only the latest stable version of crosswalk which is listed here.

The current setup may confuse some users that don't pay attention to other details when they build their apps.

Instead of doing this:

<!-- These are all equivalent -->
<preference name="xwalkVersion" value="org.xwalk:xwalk_core_library_beta:13+" />
<preference name="xwalkVersion" value="xwalk_core_library_beta:13+" />
<preference name="xwalkVersion" value="13+" />
<preference name="xwalkVersion" value="13" />

... I propose something like this:

<preference name="xwalkChannel" value="CHANNEL" />
<preference name="xwalkVersion" value="VERSION" />

... where channel possible values are: stable, beta, canary and version - the version number.
Default values: channel - stable & version - latest stable version (11 for now).

@hirbod
Copy link

hirbod commented Apr 21, 2015

@tanasebutcaru - best answer and best "way to go" 👍

@tanasebutcaru
Copy link

Also, some little issues:

  1. Right now when running cordova plugin add cordova-plugin-crosswalk-webview I get a "Not found" result.
  2. If the project has more than one platform (ie: android & ios) the plugin is installed for all:
    Uninstalling cordova-plugin-crosswalk-webview from android Uninstalling cordova-plugin-crosswalk-webview from ios

@hirbod
Copy link

hirbod commented Apr 21, 2015

@tanasebutcaru , this should be an own ticket, we should not mix up everything now

@tanasebutcaru
Copy link

@hirbod you're right. I'll open another issue. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants