Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watching files, even after moving files #264

Closed
wants to merge 1 commit into from
Closed

watching files, even after moving files #264

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 10, 2014

These changes resolved my problem concerning stopped watching files after moving them. When we do not make pushInProgress as false in the nextTick, then we never get to "return Q.all(allPromises)" once again and nothing is done, even when we register further changes.

@mmocny
Copy link
Member

mmocny commented Aug 11, 2014

Just 3 lines lower (just outside the nextTick call), these flags are set to false exactly as your patch adds.

That probably means values are reset to true right after being set to false for some reason. I'll have to take a better look to see whats going on. To be clear, you say the problem you are solving is that watch stopped working after you mv some files?

Perhaps @agrieve will know.

@agrieve agrieve closed this in 83bef53 Aug 11, 2014
@agrieve
Copy link
Member

agrieve commented Aug 11, 2014

Just stared at the code for >5 minutes before finally seeing what the bug was! Thanks for the help @tommyjs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants