Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS simulator support for KMM projects #516

Conversation

ema987
Copy link
Contributor

@ema987 ema987 commented Feb 14, 2023

Just adds iosSimulatorArm64 target to improve KMM support.

Should close #511

@ema987 ema987 force-pushed the feat/addIOSSimulatorKMMSupport branch from 18be331 to 31c19dd Compare February 14, 2023 14:09
digitalbuddha
digitalbuddha previously approved these changes Feb 14, 2023
@ema987
Copy link
Contributor Author

ema987 commented Feb 14, 2023

@digitalbuddha thank you for approving the PR
Unfortunately there was an error running the action referring to the repository/branch not found. Could a new run fix it? 🤔

@digitalbuddha
Copy link
Contributor

Rerunning let's see

@ema987
Copy link
Contributor Author

ema987 commented Feb 15, 2023

Thank you for trying but a rerun didn't solve the issue.
I had some time to see the logs and I suspect the following lines in the workflow .ci_test_and_publish.yml are causing the failure.

with:
  ref: ${{ github.event.pull_request.head.ref }}

It seems that the action is trying to fetch the repo at MobileNativeFoundation/Store with the branch created on my fork which obviously doesn't exist on your repo. Removing that line should fix the issue letting the action checkout your repo and then switch to the branch on my fork correctly.

Shall we open an issue and a new PR to fix this and then rebase this PR? How do you want to proceed?

@matt-ramotar matt-ramotar mentioned this pull request Feb 24, 2023
@matt-ramotar
Copy link
Collaborator

Hey @ema987 Mind rebasing when #520 lands and trying again?

Signed-off-by: Emanuele Papa <ema987@gmail.com>
@ema987
Copy link
Contributor Author

ema987 commented Feb 25, 2023

@matt-ramotar thank you for the CI fix. I've just rebased this PR

@matt-ramotar
Copy link
Collaborator

Let's merge and go from there I think unless @digitalbuddha has any concerns

@ema987
Copy link
Contributor Author

ema987 commented Feb 25, 2023

@matt-ramotar unfortunately it seems in #520 you fixed another workflow, not the one currently used to check PRs.
See #524 for the same fix you applied in #520, after that I can rebase this again and then it should pass the checks

@matt-ramotar
Copy link
Collaborator

There is a separate CI issue . See last night's failure for example

@matt-ramotar matt-ramotar merged commit 2cbce8a into MobileNativeFoundation:main Feb 25, 2023
@matt-ramotar
Copy link
Collaborator

Thanks @ema987!

@ema987 ema987 deleted the feat/addIOSSimulatorKMMSupport branch February 25, 2023 20:46
@ema987
Copy link
Contributor Author

ema987 commented Feb 25, 2023

Thanks to you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] iOS simulator support in Store5
3 participants