-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Rx2 #531
Merged
Merged
Support Rx2 #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
digitalbuddha
previously approved these changes
Mar 9, 2023
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
digitalbuddha
approved these changes
Apr 24, 2023
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
matt-ramotar
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Add rx2 module * Support Rx2 Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add unit tests Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Format Signed-off-by: Matt Ramotar <mramotar@dropbox.com> --------- Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
matt-ramotar
pushed a commit
that referenced
this pull request
May 8, 2023
* Superstore Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Move to impl Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add firstData Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add Superstore factory Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add README Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add SuperstoreTests Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Move to util Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Rename to primary Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Address comments from @tsenggordon Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Format Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Cover fallback to SOT on fresh fail Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Refactor based on @yigit feedback in #540 Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Enable Fetcher identification Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Cover failing fallback Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Remove superstore Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Format Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Remove logs Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Update README.md Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add Proposal template (#523) Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Support Rx2 (#531) * Add rx2 module * Support Rx2 Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Add unit tests Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Format Signed-off-by: Matt Ramotar <mramotar@dropbox.com> --------- Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Superstore Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Remove superstore Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Remove ReactiveCircus/android-emulator-runner Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Fix Rx2 merge issues Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Send failure if no fallback Signed-off-by: Matt Ramotar <mramotar@dropbox.com> * Remove Fallback interface and FallbackResponse class Signed-off-by: matt-ramotar <mramotar@dropbox.com> * Document Fetcher.name Signed-off-by: matt-ramotar <mramotar@dropbox.com> --------- Signed-off-by: Matt Ramotar <mramotar@dropbox.com> Signed-off-by: matt-ramotar <mramotar@dropbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.