Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Rx2 #531

Merged
merged 5 commits into from
Apr 24, 2023
Merged

Support Rx2 #531

merged 5 commits into from
Apr 24, 2023

Conversation

matt-ramotar
Copy link
Collaborator

No description provided.

Matt Ramotar added 2 commits March 8, 2023 20:34
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
digitalbuddha
digitalbuddha previously approved these changes Mar 9, 2023
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
@matt-ramotar matt-ramotar marked this pull request as ready for review March 9, 2023 12:18
Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
@matt-ramotar matt-ramotar merged commit 7d73f08 into main Apr 24, 2023
3 of 5 checks passed
@matt-ramotar matt-ramotar deleted the matt-ramotar/rx2 branch April 24, 2023 20:54
matt-ramotar pushed a commit that referenced this pull request Apr 26, 2023
* Add rx2 module

* Support Rx2

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add unit tests

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Format

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

---------

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
matt-ramotar pushed a commit that referenced this pull request May 8, 2023
* Superstore

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Move to impl

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add firstData

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add Superstore factory

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add README

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add SuperstoreTests

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Move to util

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Rename to primary

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Address comments from @tsenggordon

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Format

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Cover fallback to SOT on fresh fail

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Refactor based on @yigit feedback in #540

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Enable Fetcher identification

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Cover failing fallback

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Remove superstore

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Format

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Remove logs

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Update README.md

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add Proposal template (#523)

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Support Rx2 (#531)

* Add rx2 module

* Support Rx2

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Add unit tests

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Format

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

---------

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Superstore

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Remove superstore

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Remove ReactiveCircus/android-emulator-runner

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Fix Rx2 merge issues

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Send failure if no fallback

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>

* Remove Fallback interface and FallbackResponse class

Signed-off-by: matt-ramotar <mramotar@dropbox.com>

* Document Fetcher.name

Signed-off-by: matt-ramotar <mramotar@dropbox.com>

---------

Signed-off-by: Matt Ramotar <mramotar@dropbox.com>
Signed-off-by: matt-ramotar <mramotar@dropbox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants