Fix deprecation notice detection #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgilyazov
requested review from
polac24,
ecamacho,
aleksandergrzyb and
CognitiveDisson
as code owners
Signed-off-by: Lenar Gilyazov <l.gilyazov@ya.ru>
lgilyazov
force-pushed
the
deprecation-parsing-fix
branch
from
63e3208
to
0c4b01c
Compare
BalestraPatrick
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail
Some deprecation messages were not included in the final report. In cases where the message was in the
/Users/lenar/Desktop/DeprecateTest/DeprecateTest/ViewController.swift:15:9 'testDeprecate()' is deprecatedformat. I've added handling for such a message and now all deprecation messages should be captured.
Should fix #183