Skip to content

Commit

Permalink
Supporting tests and app hosts in subfolders (#419) (#427)
Browse files Browse the repository at this point in the history
If the test or app host is in subfolders, we are not able to find the generated zip/ipa files. Using short_path instead of basename would resolve the issue.

Co-authored-by: Bing Liu <liubinging@gmail.com>
  • Loading branch information
chenxiao0228 and Biinngg committed Mar 24, 2020
1 parent 818c3fb commit a5e6eae
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bptestrunner/bluepill_batch_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ def _bluepill_batch_test_impl(ctx):
test_host = test_info.test_host
test_bundle = test_info.test_bundle
if test_bundle:
test_bundle_paths.append("\"{}\"".format(test_bundle.basename))
test_bundle_paths.append("\"{}\"".format(test_bundle.short_path))
runfiles.append(test_bundle)

if test_host and test_host not in runfiles:
test_host_paths.append("\"{}\"".format(test_host.basename))
test_host_paths.append("\"{}\"".format(test_host.short_path))
runfiles.append(test_host)

#test_plan
Expand Down

0 comments on commit a5e6eae

Please sign in to comment.