Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 9.2 #219

Merged
merged 2 commits into from Jan 19, 2018
Merged

Xcode 9.2 #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46a0866
Minor fixes for XCode 9.2
ob Nov 29, 2017
26368c2
Merge branch 'master' into xcode-9.2
ob Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bluepill-runner/Bluepill-runner/BPApp.m
View file
Open in desktop
Expand Up @@ -137,7 +137,7 @@ + (instancetype)appWithConfig:(BPConfiguration *)config
[allTests addObject:testFile];
}
}

app.testBundles = allTests;
return app;
}
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Expand Up @@ -98,10 +98,11 @@ A full list supported options are listed here.

## Requirements

Bluepill only works with **Xcode 9.1**. If you're looking for old Xcode support, please check out the other branches:
Bluepill only works with **Xcode 9.2**. If you're looking for old Xcode support, please check out the other branches:

* [Xcode-8](https://github.com/linkedin/bluepill/tree/xcode8)
* [Xcode-9.0](https://github.com/linkedin/bluepill/tree/xcode-9.0)
* [Xcode-9.1](https://github.com/linkedin/bluepill/tree/xcode-9.1)

## Acknowledgement

Expand Down
4 changes: 2 additions & 2 deletions Source/Shared/BPConstants.h
View file
Open in desktop
Expand Up @@ -9,9 +9,9 @@

#import <Foundation/Foundation.h>

#define BP_DEFAULT_RUNTIME "iOS 11.1"
#define BP_DEFAULT_RUNTIME "iOS 11.2"
#define BP_DEFAULT_DEVICE_TYPE "iPhone 7"
#define BP_DEFAULT_XCODE_VERSION "Xcode 9.1"
#define BP_DEFAULT_XCODE_VERSION "Xcode 9.2"
#define BP_TM_PROTOCOL_VERSION 17
#define BP_DAEMON_PROTOCOL_VERSION 24
#define BP_MAX_PROCESSES_PERCENT 0.75
Expand Down
2 changes: 1 addition & 1 deletion circle.yml
View file
Open in desktop
@@ -1,6 +1,6 @@
machine:
xcode:
version: 9.1
version: 9.2

compile:
override:
Expand Down
1 change: 0 additions & 1 deletion scripts/bluepill.sh
View file
Open in desktop
Expand Up @@ -85,7 +85,6 @@ bluepill_build_sample_app()
-workspace Bluepill.xcworkspace \
-scheme BPSampleApp \
-sdk iphonesimulator \
-destination 'platform=iOS Simulator,name=iPhone 7,OS=11.1' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this deleted ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary. When building the app, if the destination doesn't exit (for example because you upgraded Xcode and there is no 11.1 iOS runtime) the build fails.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean exist instead of exit ? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol yeah...

-derivedDataPath "build/" 2>&1 | tee result.txt | $XCPRETTY

test $? == 0 || {
Expand Down