Allow .xctestrun equivalent in config.json #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob
reviewed
Sep 17, 2019
|
Also, it could use some docs about the new keys in the config file. Oh, and some tests |
More changes Add additional keys Clean up BPTestPlan code. Validate BPTestPlans Bazel batch tests (#389) * Bazel support for Bluepill batch test mode. Batch test mode is the equivilent of an xctestrun file that's built by Xcode from a xcscheme. It has information to run a set of test targets. Bluepill will read a test plan json, which has configurations of each test targets, then split and pass it to BP sessions to run the tests. Changes: Added bluepill_batch_test rule Added bluepill_batch_test_runner.template.sh, the rule will generate the sh from itto setup workspace for bluepill then call it. Changed BPConfiguration to accept a test plan file. * Added support for time estimate json support in Bazel batch test rule * Corrected batch test runner script to return the right RC and copy logs Remove test outputs after copying
Co-Authored-By: Oscar Bonilla <obonilla@linkedin.com>
chenxiao0228
pushed a commit
that referenced
this pull request
Nov 19, 2019
Bazel support for Bluepill batch test mode. Batch test mode is the equivilent of an xctestrun file that's built by Xcode from a xcscheme. It has information to run a set of test targets. Bluepill will read a test plan json, which has configurations of each test targets, then split and pass it to BP sessions to run the tests. Added bluepill_batch_test rule Added bluepill_batch_test_runner.template.sh, the rule will generate the sh from itto setup workspace for bluepill then call it. Changed BPConfiguration to accept a test plan file. Added support for time estimate json support in Bazel batch test rule (cherry picked from commit 97f36f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for the the config file to contain info usually stored in a .xctestrunfile run file.
Example config: https://gist.github.com/bdittmer/9c131fa94ca36daf8c70e3014c87c51e
Example run w/ config: https://gist.github.com/bdittmer/9ce90fece7308d7192f6c4f6bbd98e7a
Addresses #358