Bluepill w/ Xcode 11 support, more logging, minor fixes and partial revert of bugfix in PR#338 #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob
reviewed
Sep 18, 2019
BPSampleApp/BPSampleAppCrashingTests/BPSampleAppCrashingTests.m
Outdated
Show resolved
Hide resolved
ravimandala
force-pushed
the
master
branch
4 times, most recently
from
7ae0aff
to
3b31024
Compare
ravimandala
changed the title
|
@ob I updated this PR with the below changes...
Can you please take another look? |
ob
approved these changes
Sep 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am looking for a Bluepill version to be used w/ Xcode 11.
Can you please merge this PR and generate a Bluepill release with the fix to #338 reverted and more logging added (cherry-picked a commit from your branch https://github.com/linkedin/bluepill/tree/more-logging)? I tested this on machines with Xcode 11 GM Seed#1.
Thanks. \cc @ob