Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xcode 11.2 Support #392

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Xcode 11.2 Support #392

merged 1 commit into from
Nov 15, 2019

Conversation

ob
Copy link
Member

@ob ob commented Nov 13, 2019 •
edited
Loading

Bump to support Xcode 11.2.

Fixes #391

@ob ob mentioned this pull request Nov 13, 2019
Closed
@ravimandala
Copy link
Contributor

Triggered the checks again, as GH Actions were stuck.

@ravimandala ravimandala self-requested a review November 14, 2019 21:09
@pattogato
Copy link

@ravimandala Checks has passed

ravimandala
ravimandala approved these changes Nov 15, 2019
View reviewed changes
Copy link
Contributor

@ravimandala ravimandala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ravimandala ravimandala merged commit 065f4b3 into master Nov 15, 2019
@jerrymarino
Copy link
Contributor

What do you all think about making these variables more dynamic? With Apple's recent Xcode cadence we're having to do a lot of rebuilds / rebasing to update these. I can take a look at adding this in

@ravimandala
Copy link
Contributor

@jerrymarino Is is possible to use arbitrary config values in .yml files in place of these hardcoded values? If so, we can put these configs in one file rather than changing it in multiple files.
Even better, since Github supports macOS-latest it should also support something like xcode_latest in .yml configurations. Sorry, I closed the PR before Oscar responded, but please feel free to create an issue if you think that's feasible.

@ob
Copy link
Member Author

ob commented Nov 15, 2019

@jerrymarino what do you have in mind?

@ravimandala ravimandala deleted the ob/xcode-11.2 branch November 20, 2019 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravimandala ravimandala ravimandala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Xcode 11.2
4 participants
@ob @ravimandala @pattogato @jerrymarino