Fix a hang when the app we're testing crashes on launch #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the function a bit easier to read.
oliverhu
reviewed
Jan 15, 2017
| return; | ||
| } else { | ||
| // App crashed | ||
| [[BPStats sharedStats] addSimulatorLaunchFailure]; |
There was a problem hiding this comment.
This is not simulator launch failure but app launch failure, create another entry for this case?
RainNapper
pushed a commit
to RainNapper/bluepill
that referenced
this pull request
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few cosmetic commits plus a fix for when the app we're testing crashes on launch.
Still not done is the reporting so I'm not completely closing #3 but this gets us closer.
I think Ashit should double check this change but he's still not listed as a project owner 😞