Merge exit code fixes from PR#432 and PR#430 to Xcode 11.2 branch #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ativeFoundation#432) Also, log when retry count exceeded max retries. Co-authored-by: Mansfield Mark <mmark@pinterest.com>
… final Exit Status issues (MobileNativeFoundation#430) * Adding the ability to mock different test executions in Bluepill * Add a few more tests and fixed the exit status issues Changing the Exit Status to powers of 2 to make them mergeable. Easy consolidation/aggregation of exit code. In case of failure reporting, report all exit status that happened over multiple attempts, if any. Prevent extra attempt, which does nothing, by eliminating the use of `hasRemainingTestsInContext` which is not accurate. * Re-enabling some disabled/skipped BP tests and fixed a fragile packer test A fragile packer test broke when the total number of tests changed. So, fixed the testing method to fix the test. Also, re-enabled a few tests in BluepillTests that were being skipped/disabled for some reason. * Renaming BPExitStatusTestsAllPassed to BPExitStatusAllTestsPassed Renaming the all-good exit status from BPExitStatusTestsAllPassed to BPExitStatusAllTestsPassed and incorporated comments. Tweaked the tests a bit to reduce the regression testing duration.
|
Thank you Oscar for the approval. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to merge the exit code fixes/improvements from #432 and #430 in to
xcode-11.2branch with Xcode 11.2 support.\cc @ob @oliverhu @chenxiao0228 @RainNapper