Fix hangs #49
Merged
Fix hangs #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ob
approved these changes
Feb 3, 2017
| self.config.testing_CrashAppOnLaunch = YES; | ||
| self.config.testing_NoAppWillRun = NO; | ||
| BPExitStatus exitCode = [[[Bluepill alloc ] initWithConfiguration:self.config] run]; | ||
| NSLog(@"%ld", (long)exitCode); |
There was a problem hiding this comment.
I would remove these NSLog (and the one in the next function).
| // If it's not running and we passed the above checks (e.g., the tests are not yet completed) | ||
| // then it must mean the app has crashed. | ||
| // However, we have a short-circuit for tests because those may not actually run any app | ||
| if (!isRunning && context.pid > 0 && !self.config.testing_NoAppWillRun) { |
There was a problem hiding this comment.
The testing_NoAppWillRun variable is for the parsing tests right? I would then maybe also use it in the kill() below where I am just looking for self.appPID == 0 for the same case.
This is the other half of the previous commit. I don't know how it didn't get committed.
This was referenced Feb 7, 2017
RainNapper
pushed a commit
to RainNapper/bluepill
that referenced
this pull request
Jun 16, 2021
PyCQA/isort#1429 fixed --check's output so that the error message and diff output are separated into STDERR and STDOUT rather than combined in STDOUT. This means we need to update our diff parsing function accordingly. Also fix the version parsing routine to read from STDOUT. This was busted for at least a few versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates the two tests that @ob added and includes fixes for detecting situations where the app fails to launch successfully, or we fail to detect that an app has frozen because the tests were not in the "Running" state. This also addresses an ask from @ob for a clearer message when the app crashes before tests have begun.