Add -file-prefix-map option
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-file-prefix-map` option allows setting the `PathRemapper` mappings the same way that `clang` does. We now also use the `PathRemapper` in `getUnitPathForOutputFile` the same as as `IndexUnitWriter`. This change is needed to allow the use of both the `swift.use_global_index_store` and `swift.file_prefix_map` rules_swift features. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
force-pushed
the
bj/add-file-prefix-map-option
branch
from
2c379fc
to
c8aa124
Compare
keith
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-file-prefix-mapoption allows setting thePathRemappermappings the same way thatclangdoes. We now also use thePathRemapperingetUnitPathForOutputFilethe same as asIndexUnitWriter.This change is needed to allow the use of both the
swift.use_global_index_storeandswift.file_prefix_maprules_swift features.