Absolutize paths after remapping #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index store library requires paths being written are absolute. If we don't absolutize them then it does. Unfortunately its logic for that computes the PWD for every single path, which can amount to ~5% of the total time spent in index-import. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
Turns out, we had tons of relative paths for header/source files (.h and .m) and was able to benefit performance from this change, yet again. Before : ~50 seconds Thanks @keith ! |
brentleyjones
approved these changes
Jun 27, 2023
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
added a commit
that referenced
this pull request
Jul 5, 2023
Absolutizing these paths resulted in failures with symlinks downstream. Resolving those symlinks seems to work but in the case you're trying to remap from 1 location to another not for Xcode, which rules_swift does if you use the `swift.use_global_index_store` you actually need the paths to still be relative in the units. This reverts commit 431d4e5. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
keith
added a commit
that referenced
this pull request
Jul 5, 2023
Absolutizing these paths resulted in failures with symlinks downstream. Resolving those symlinks seems to work but in the case you're trying to remap from 1 location to another not for Xcode, which rules_swift does if you use the `swift.use_global_index_store` you actually need the paths to still be relative in the units. This reverts commit 431d4e5. Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index store library requires paths being written are absolute. If we
don't absolutize them then it does. Unfortunately its logic for that
computes the PWD for every single path, which can amount to ~5% of the
total time spent in index-import.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com