Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Issues in External Repositories don't resolve to a valid path #482

Closed
Tracked by #618
brentleyjones opened this issue May 31, 2022 · 1 comment · Fixed by #893
Closed
Tracked by #618

Bug: Issues in External Repositories don't resolve to a valid path #482

brentleyjones opened this issue May 31, 2022 · 1 comment · Fixed by #893
Assignees
Labels
bug Something isn't working BwB Related to Build with Bazel mode

Comments

@brentleyjones
Copy link
Contributor

Describe the bug

Screenshot showing non-clickable warnings originating from External Repositories

The issue is the build log has paths based on the exec root, which lists external dependences at external/, instead of the Xcode visible path of $(BAZEL_EXTERNAL)/ (which is something like $(PROJECT_FILE_PATH)/rules_xcodeproj/links/external):

INFO: From Compiling Swift module @com_github_pointfreeco_swift_custom_dump//:CustomDump:
external/com_github_pointfreeco_swift_custom_dump/Sources/CustomDump/Conformances/UserNotifications.swift:154:10: warning: 'alert' was deprecated in macOS 11.0
        .alert,
         ^
external/com_github_pointfreeco_swift_custom_dump/Sources/CustomDump/Conformances/UserNotifications.swift:154:10: warning: 'alert' was deprecated in macOS 11.0
        .alert,
         ^
external/com_github_pointfreeco_swift_custom_dump/Sources/CustomDump/Conformances/UserNotifications.swift:135:32: warning: 'alert' was deprecated in macOS 11.0
          if self.rawValue == .alert {
                               ^
[51 / 60] Compiling Swift module @com_github_tuist_xcodeproj//:XcodeProj; 5s worker ... (2 actions, 1 running)

INFO: From Compiling Swift module @com_github_tuist_xcodeproj//:XcodeProj:
external/com_github_tuist_xcodeproj/Sources/XcodeProj/Workspace/XCWorkspace.swift:31:70: warning: 'self' refers to the method 'XCWorkspace.self', which may be unexpected
        let data = XCWorkspaceData(children: [.file(.init(location: .self("")))])
                                                                     ^
external/com_github_tuist_xcodeproj/Sources/XcodeProj/Workspace/XCWorkspace.swift:31:70: note: use 'XCWorkspace.self' to silence this warning
        let data = XCWorkspaceData(children: [.file(.init(location: .self("")))])
                                                                     ^
                                                                     XCWorkspace.
external/com_github_tuist_xcodeproj/Sources/XcodeProj/Workspace/XCWorkspaceDataElementLocationType.swift:65:21: warning: 'self' refers to the method 'XCWorkspaceDataElementLocationType.self', which may be unexpected
            self = .self(path)
                    ^
external/com_github_tuist_xcodeproj/Sources/XcodeProj/Workspace/XCWorkspaceDataElementLocationType.swift:65:21: note: use 'XCWorkspaceDataElementLocationType.self' to silence this warning
            self = .self(path)
                    ^
                    XCWorkspaceDataElementLocationType.

We need to post-process the output to change the paths. The same post-processing will probably be needed to fix #458.

@brentleyjones brentleyjones added bug Something isn't working BwB Related to Build with Bazel mode labels May 31, 2022
@brentleyjones brentleyjones added this to the Before 1.0 milestone May 31, 2022
@brentleyjones
Copy link
Contributor Author

Depending on how we handle #400/#402, we might just stop showing these versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working BwB Related to Build with Bazel mode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant