Fix issues not navigating to source files in BwB mode #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bazel using relative paths breaks Xcode's handling of error paths in the build log. Also, `external/` and `bazel-out/` prefixes need to be translated to be based on the `$BAZEL_OUT` and `$BAZEL_EXTERNAL` build settings, which are probably rooted somewhere in `/var/tmp`. As a bonus, strip out color ANSI codes in the log, and force color to be on. This brings color back to BES logs. Thank you @keith for providing me with a baseline implementation of this!
cgrindel
approved these changes
Aug 5, 2022
brentleyjones
deleted the
bj/fix-issues-not-navigating-to-source-files-in-bwb-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #482.
Bazel using relative paths breaks Xcode's handling of error paths in the build log. Also,
external/andbazel-out/prefixes need to be translated to be based on the$BAZEL_OUTand$BAZEL_EXTERNALbuild settings, which are probably rooted somewhere in/var/tmp.As a bonus, it strips out color ANSI codes in the log, and forces color to be on. This brings color back to BES logs.
Thank you @keith for providing me with a baseline implementation of this!