Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spec writing to sort keys and select values. #123

Merged
merged 9 commits into from
Mar 10, 2022
Merged

Update spec writing to sort keys and select values. #123

merged 9 commits into from
Mar 10, 2022

Conversation

cgrindel
Copy link
Contributor

Closes #122

  • Added flattened_key_values library to support sorting of flattened key-values.
  • Updated xcodeproj to sort Xcode targets, potential target merges, and required links.
  • Updated the validator.template.sh to sort the JSON keys before performing the diff.

Copy link
Contributor

@brentleyjones brentleyjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

xcodeproj/internal/flattened_key_values.bzl Outdated Show resolved Hide resolved
xcodeproj/xcodeproj.bzl Outdated Show resolved Hide resolved
@brentleyjones
Copy link
Contributor

Tests aren't running because of a known issue with PRs from forks. I'll run the tests locally and merge if they pass.

@brentleyjones brentleyjones merged commit 6454440 into MobileNativeFoundation:main Mar 10, 2022
@cgrindel cgrindel deleted the fix_spec_diff_test branch March 10, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Make the spec diff tests more resilient
2 participants