Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linking for apple_static_framework_import #258

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix linking for apple_static_framework_import #258

merged 1 commit into from
Apr 7, 2022

Conversation

brentleyjones
Copy link
Contributor

Part of #71.

@brentleyjones brentleyjones force-pushed the bj/fix-static-framework-imports branch 2 times, most recently from d7f300e to 9eaf688 Compare April 7, 2022 00:48
@brentleyjones brentleyjones force-pushed the bj/fix-static-framework-imports branch from 9eaf688 to 674a51a Compare April 7, 2022 15:03
@brentleyjones brentleyjones enabled auto-merge (squash) April 7, 2022 15:03
erikkerber
erikkerber approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@erikkerber erikkerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got our project to build to completion

@brentleyjones brentleyjones merged commit 14641f1 into main Apr 7, 2022
@brentleyjones brentleyjones deleted the bj/fix-static-framework-imports branch April 7, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikkerber erikkerber erikkerber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brentleyjones @erikkerber