Remove TARGET_DEVICE_PLATFORM_NAME matching from Info.plist touching
#2936
Conversation
|
Hmm, this was specifically set to that because the change was only needed to fix a device deployment issue. Are you saying that the same issue exists on the simulator? |
brentleyjones
changed the title
TARGET_DEVICE_PLATFORM_NAME matching
|
Does this issue also happen for tvOS? Maybe we need to remove the |
|
@brentleyjones Thats correct; it appears to happen on simulator as well. Devs have been reporting that source code changes aren’t reflected in test host target apps. |
Haven't tried with tvOS, but logically it makes sense to apply to all platforms? I can add that as a part of this change if you'd like. |
|
Yes please. Also you need to sign-off on your git commit to pass the |
sebastianv1
force-pushed
the
sebastianv1/fix-plist-touch
branch
2 times, most recently
from
bc08a7f
to
4365b21
Compare
brentleyjones
changed the title
TARGET_DEVICE_PLATFORM_NAME matchingTARGET_DEVICE_PLATFORM_NAME matching from Info.plist touching
It appears that the `TARGET_DEVICE_PLATFORM_NAME` check didn't account for `iphonesimulator` platform name which was causing unit tests running on a test host to not reflect changes made in source code. Signed-off-by: Sebastian Shanus <sebastian.shanus@robinhood.com>
brentleyjones
force-pushed
the
sebastianv1/fix-plist-touch
branch
from
4365b21
to
40df51e
Compare
It appears that the
TARGET_DEVICE_PLATFORM_NAMEcheck didn't account foriphonesimulatorplatform name which was causing unit tests running on a test host to not reflect changes made in source code.