Fix don't attempt to get extension_host for launch_path #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
changed the title
|
I think we can have a unit test covering this (even adjusting an existing one if possible). |
thiagohmcruz
approved these changes
Apr 4, 2024
|
🤔 somehow a private PR mentioning this PR closed it? Weird... Working on tests now |
luispadron
force-pushed
the
luis/fix-launch-path
branch
from
a635a1a
to
1a5a7a9
Compare
That's funny. |
The `launch_path` does not have an `extension_host` attr Signed-off-by: Luis Padron <lpadron@squareup.com>
luispadron
force-pushed
the
luis/fix-launch-path
branch
from
1a5a7a9
to
ae90937
Compare
brentleyjones
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
launch_pathdoes not have anextension_hostattr