Fix explosive memory use of inefficient _process_dependencies()
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/fix-explosive-memory-use-of-inefficient-_process_dependencies
branch
from
2155d8a
to
b9275fb
Compare
This is why `depset` exists. This also fixes the extra configured targets in `//examples/command_line` for some reason 🤷♂️.
brentleyjones
force-pushed
the
bj/fix-explosive-memory-use-of-inefficient-_process_dependencies
branch
from
b9275fb
to
3e88d79
Compare
brentleyjones
deleted the
bj/fix-explosive-memory-use-of-inefficient-_process_dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.
This is why
depsetexists.