Determine bazel-out and external paths at build time
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/determine-bazel-out-and-external-paths-at-build-time
branch
from
1d04907
to
6670eed
Compare
This removes the need for test fixtures to be slightly different from normal projects. It will also be needed for future Indexing improvements, which will make the symlinks in the workspace unreliable. Finally, this fixes the issue builds breaking after relocating the workspace.
brentleyjones
force-pushed
the
bj/determine-bazel-out-and-external-paths-at-build-time
branch
from
6670eed
to
07fb64e
Compare
brentleyjones
commented
Apr 18, 2022
| @@ -1796,7 +1801,7 @@ | |||
| ENABLE_TESTING_SEARCH_PATHS = YES; | |||
| FRAMEWORK_SEARCH_PATHS = ( | |||
| "$(PROJECT_DIR)/third_party", | |||
| "$(PROJECT_DIR)/bazel-ios_app/external/examples_ios_app_external", | |||
| "$(BAZEL_EXTERNAL)/examples_ios_app_external", | |||
There was a problem hiding this comment.
Besides for being shorter, I like that these are more readable, especially in diffs.
cgrindel
approved these changes
Apr 18, 2022
brentleyjones
deleted the
bj/determine-bazel-out-and-external-paths-at-build-time
branch
brentleyjones
added a commit
that referenced
this pull request
Apr 18, 2022
These should have been deleted with #319.
Merged
brentleyjones
added a commit
that referenced
this pull request
Apr 18, 2022
These should have been deleted with #319.
brentleyjones
added a commit
that referenced
this pull request
Apr 19, 2022
This path should have changed with #319.
brentleyjones
added a commit
that referenced
this pull request
Apr 19, 2022
This path should have changed with #319.
brentleyjones
added a commit
that referenced
this pull request
Apr 19, 2022
This path should have changed with #319.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201.
This removes the need for test fixtures to be slightly different from normal projects. It will also be needed for future Indexing improvements, which will make the symlinks in the workspace unreliable. Finally, this fixes the issue builds breaking after relocating the workspace.