Add support for code signing entitlements in Xcode build #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this depends on bazelbuild/rules_apple#1456 to work correctly. I plan on updating our version of rules_apple soon though. |
|
Fixtures need an update after the rules_apple change (which is good!) |
This was referenced Apr 29, 2022
BalestraPatrick
force-pushed
the
pb/xcode-code-signing-entitlements
branch
from
97bcb5e
to
3360bc9
Compare
brentleyjones
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #72 and #96.
This PR adds support for fetching the produced
entitlementsfile and setting the right build settings in Xcode. This allows to build the app with the correct entitlements inside of Xcode.