Use Objective-C instead of Swift for compile stub #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrindel
approved these changes
Apr 29, 2022
This resolves some PCM related warnings, but also makes handling these types of targets easier in Build with Bazel mode. Note, this change does cause the resource bundles to have `OTHER_LDFLAGS` set, but it does no harm, and for bundles that do have executables it would be needed anyway.
brentleyjones
force-pushed
the
bj/use-objective-c-instead-of-swift-for-compile-stub
branch
from
e2d3823
to
fe1b09a
Compare
brentleyjones
deleted the
bj/use-objective-c-instead-of-swift-for-compile-stub
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves some PCM related warnings, but also makes handling these types of targets easier in Build with Bazel mode.
Note, this change does cause the resource bundles to have
OTHER_LDFLAGSset, but it does no harm, and for bundles that do have executables it would be needed anyway.