Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out non-header files from Compile Source phase #469

Merged

Conversation

maxwellE
Copy link
Contributor

@maxwellE maxwellE commented May 24, 2022

Fixes #414.

Filters out non-header files from publicHeaders
@brentleyjones brentleyjones changed the title Filters out non-header files from publicHeaders Filter out non-header files from Compile Source phase May 24, 2022
@brentleyjones
Copy link
Contributor

Looks like you need to update the fixtures: https://github.com/buildbuddy-io/rules_xcodeproj/blob/main/CONTRIBUTING.md#developing

tools/generator/src/Generator+AddTargets.swift Outdated Show resolved Hide resolved
@brentleyjones
Copy link
Contributor

Some changes are needed in Fixtures.swift. You should be able to run the tests locally with bazel test --config=cache //tools/....

@tinder-maxwellelliott
Copy link

Some changes are needed in Fixtures.swift. You should be able to run the tests locally with bazel test --config=cache //tools/....

On it now

@maxwellE
Copy link
Contributor Author

maxwellE commented May 24, 2022

Some changes are needed in Fixtures.swift. You should be able to run the tests locally with bazel test --config=cache //tools/....

@brentleyjones How do you debug these AssertNoDifferences, I only get a subset of the change and I cannot easily tell which target owns the added PBXObjectReference

@brentleyjones
Copy link
Contributor

Yeah, sometimes the diffs hide context. For these though, you know you are removing files from the Compile Sources, so you'll need to remove things from PBXSourcesBuildPhase initializers (or the phases all together) for targets that had headers there. One example is PBXBuildFile(file: elements["z.h"]!),.

@brentleyjones brentleyjones merged commit 6b4d177 into MobileNativeFoundation:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Non-processable file warning for non-source code files
4 participants