Move Configuration distinguisher logic up a level #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/disambiguate-less
branch
from
3be30b5
to
31f26b8
Compare
brentleyjones
force-pushed
the
bj/move-distinguisherKey-check
branch
from
439bdaf
to
bbbb76c
Compare
brentleyjones
force-pushed
the
bj/disambiguate-less
branch
from
31f26b8
to
4f09364
Compare
This changes the configuration to be on it's own in the name: ``` A (iOS) (abcde) ``` instead of: ``` A (iOS, abcde) ``` This is needed to support consolidated targets, which will have something like this when a configuration needs to be displayed: ``` A (iOS, tvOS) (abcde) ```
brentleyjones
force-pushed
the
bj/move-distinguisherKey-check
branch
from
bbbb76c
to
fc29e39
Compare
jpsim
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the configuration to be on it's own in the name:
instead of:
This is needed to support consolidated targets, which will have something like this when a configuration needs to be displayed: