Use AppleResourceInfo for resource file collection
#564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
changed the base branch from
main
to
bj/add-more-complicated-resource-bundles
brentleyjones
force-pushed
the
bj/use-AppleResourceInfo-for-resource-file-collection
branch
2 times, most recently
from
06a50d5
to
c1940b9
Compare
brentleyjones
commented
Jun 21, 2022
Comment on lines
68
to
70
| target_type = struct( | ||
| compile = "compile", | ||
| resources = "resources", | ||
| ) |
There was a problem hiding this comment.
This whole struct will be removed after PR, as this reworking unblocks further reworking of input file and transitive dependency processing.
brentleyjones
force-pushed
the
bj/use-AppleResourceInfo-for-resource-file-collection
branch
from
c1940b9
to
3ab779e
Compare
Base automatically changed from
bj/add-more-complicated-resource-bundles
to
main
June 21, 2022 21:06
BalestraPatrick
approved these changes
Jun 21, 2022
brentleyjones
force-pushed
the
bj/use-AppleResourceInfo-for-resource-file-collection
branch
from
3ab779e
to
4f4fc28
Compare
brentleyjones
deleted the
bj/use-AppleResourceInfo-for-resource-file-collection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228.