Fix breakpoints set from swiftsourceinfo views #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
changed the base branch from
bj/consolidate-copy-files-script-into-bazel-build-script
to
main
swiftsourceinfo files use the non-Project navigator symlinked paths, so we need to add those versions to lldb's `target.source-map` as well. This is particularly noticeable when using Focused Projects, as the swiftsourceinfo might be one of the main ways you navigate to a module's source code to set a breakpoint.
brentleyjones
force-pushed
the
bj/fix-breakpoints-set-from-swiftsourceinfo-views
branch
from
5019022
to
1661f15
Compare
BalestraPatrick
approved these changes
Jun 23, 2022
brentleyjones
deleted the
bj/fix-breakpoints-set-from-swiftsourceinfo-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swiftsourceinfo files use the non-Project navigator symlinked paths, so we need to add those versions to lldb's
target.source-mapas well.This is particularly noticeable when using Focused Projects, as the swiftsourceinfo might be one of the main ways you navigate to a module's source code to set a breakpoint.