Fix search paths for non-merged top-level targets #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
approved these changes
Jul 12, 2022
Collecting and merging of `CcInfo` and `ObjcProvider` providers was extracted out of `linker_input_files` to all for its use in `process_search_paths`. `process_search_paths` now uses these providers to get the search paths, allowing top-level targets to have correct search paths, which matters when they aren't merged with a library target.
brentleyjones
force-pushed
the
bj/fix-search-paths-for-non-merged-top-level-targets
branch
from
3fea433
to
26fb517
Compare
brentleyjones
deleted the
bj/fix-search-paths-for-non-merged-top-level-targets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting and merging of
CcInfoandObjcProviderproviders was extracted out oflinker_input_filesto all for its use inprocess_search_paths.process_search_pathsnow uses these providers to get the search paths, allowing top-level targets to have correct search paths, which matters when they aren't merged with a library target.