Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $BAZEL_OUT for modulemaps and header search paths #761

Merged

Conversation

brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Jul 18, 2022

To make this work in BwX mode, a VFS overlay was added to cause the Xcode produced Swift generated headers to take precedence over Bazel ones.

@brentleyjones brentleyjones force-pushed the bj/use-bazel_out-for-modulemaps-and-header-search-paths branch 3 times, most recently from adce3b3 to 94237d3 Compare July 19, 2022 12:47
@brentleyjones
Copy link
Contributor Author

@BalestraPatrick (since your setup is the best case for modulemaps, imo)

To make this work in BwX mode, a VFS overlay was added to cause the Xcode produced Swift generated headers to take precedence over Bazel ones.
@brentleyjones brentleyjones force-pushed the bj/use-bazel_out-for-modulemaps-and-header-search-paths branch from 94237d3 to 801ff91 Compare July 19, 2022 14:05
Copy link
Contributor

@BalestraPatrick BalestraPatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine in BwX mode!

@brentleyjones brentleyjones merged commit 0fdbbdf into main Jul 19, 2022
@brentleyjones brentleyjones deleted the bj/use-bazel_out-for-modulemaps-and-header-search-paths branch July 19, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants