Properly merge mixed provider linking contexts #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalestraPatrick
approved these changes
Jul 21, 2022
This doesn't pop up for top level targets with a single dep (which is all of our examples), but if we were to perform merging of providers at lower levels (which will be needed for a later change), then we currently need to "upgrade" `CcInfo` to `ObjcProvider` to get all of the linking information.
brentleyjones
force-pushed
the
bj/properly-merge-mixed-provider-linking-contexts
branch
from
9935106
to
f850330
Compare
brentleyjones
deleted the
bj/properly-merge-mixed-provider-linking-contexts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't pop up for top level targets with a single dep (which is all of our examples), but if we were to perform merging of providers at lower levels (which will be needed for a later change), then we currently need to "upgrade"
CcInfotoObjcProviderto get all of the linking information.