Calculate ExtensionPointIdentifier without compiling XCAssets
#797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
force-pushed
the
bj/selective-generated-files
branch
from
f1a7bb0
to
a530936
Compare
brentleyjones
force-pushed
the
bj/more-efficient-parse_extensionpointidentifiers
branch
from
1c36cc7
to
1e1fd0e
Compare
brentleyjones
force-pushed
the
bj/selective-generated-files
branch
from
a530936
to
aaf08e3
Compare
brentleyjones
force-pushed
the
bj/more-efficient-parse_extensionpointidentifiers
branch
from
1e1fd0e
to
11b0c14
Compare
brentleyjones
force-pushed
the
bj/selective-generated-files
branch
from
aaf08e3
to
786561b
Compare
brentleyjones
force-pushed
the
bj/more-efficient-parse_extensionpointidentifiers
branch
from
11b0c14
to
eac75a2
Compare
brentleyjones
force-pushed
the
bj/selective-generated-files
branch
from
786561b
to
70e925f
Compare
brentleyjones
force-pushed
the
bj/more-efficient-parse_extensionpointidentifiers
branch
from
eac75a2
to
78360b4
Compare
cgrindel
approved these changes
Jul 21, 2022
brentleyjones
force-pushed
the
bj/selective-generated-files
branch
from
70e925f
to
396af60
Compare
Using the Bazel generated Info.plist to calculate `ExtensionPointIdentifier` adds an implicit dependency on `AssetCatalogCompile`. We only need to "merge" the hand provided Info.plists, which we do by processing multiple Info.plists for a target, in order.
brentleyjones
force-pushed
the
bj/more-efficient-parse_extensionpointidentifiers
branch
from
78360b4
to
5a0f598
Compare
brentleyjones
deleted the
bj/more-efficient-parse_extensionpointidentifiers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Bazel generated Info.plist to calculate
ExtensionPointIdentifieradds an implicit dependency onAssetCatalogCompile. We only need to "merge" the hand provided Info.plists, which we do by processing multiple Info.plists for a target, in order.