-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set target.swift-*
lldb settings
#836
Conversation
df80de1
to
3a7390b
Compare
Almost there. These two keys don't match. Trying to figure out when we need to add the minimum os to the triple:
|
I swear I was seeing the triples without the os version before. Now I only see the one with os version. Maybe I can add a fallback key lookup just in case... |
3a7390b
to
c2cb45b
Compare
Regardless, latest issue is that these two don't match:
I have |
And now it works. Hmmmmm 🤔. I'm thinking it was some sort of caching issue (multiple Xcode projects open, both of them stopped in lldb...), so we just need the one backup now, though maybe I can convert the lldb one to the generic one when doing that. The downside is the small chance of collisions if there are multiple versions of executable paths that only differ on os version, but the backup is better than nothing. |
c2cb45b
to
f595e70
Compare
Fallback added, I think this is good to go. @jpsim It would be nice to make sure that this doesn't regress debugging for EM. It doesn't set the flag that removes debug information ( @cgrindel can you test this on your internal project as well? |
(And I found the 11.0 vs 12.0, and it's related to generator's tests. Digging in.) |
f595e70
to
6d61bc9
Compare
And now that is fixed! Was looking at yet another wrong place for the triple. So many places to get it in lldb... |
93a93fa
to
08626b7
Compare
Lightweight debugging testing with EM seems to still work. I didn't review the changes here in depth though, there's a lot that was touched. |
112d9ce
to
638aa0d
Compare
This allows lldb to work correctly if using the `-serialize-debugging-options` `swiftc` flag.
638aa0d
to
43df10f
Compare
I got a couple offline reports of this working, so merging. |
Part of #617.
This allows lldb to work correctly if using the
-noserialize-debugging-options
swiftc
flag.