Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/recommend internal ids #70

Merged
merged 9 commits into from Nov 28, 2023
Merged

Conversation

feldlime
Copy link
Collaborator

@feldlime feldlime commented Nov 26, 2023

  • Added ability to pass internal ids to recommend and recommend_to_items methods and get internal ids back
  • Fixed bug in LastNSplitter with incorrect i_split in info

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9b3992e) 100.00% compared to head (68a4bf7) 100.00%.
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #70   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         2242      2307   +65     
=========================================
+ Hits          2242      2307   +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
rectools/models/base.py Outdated Show resolved Hide resolved
@feldlime feldlime merged commit 8b8a3a1 into main Nov 28, 2023
9 checks passed
@feldlime feldlime deleted the feature/recommend_internal_ids branch November 28, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants