Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-8511] Allow table name to have format db.schema.table #21

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Sep 1, 2023

Kafka does not have restrictions for topic names, so some.topic.name is a valid string. But currently Table class (used in DBReader.source and DBWriter.target) does not allow such names.

This restriction was cause by validator which separated db.name to separated fields db and name. Replaced it with just one field name, bumped version to 1.4.0.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #21 (4c9b697) into develop (0d4bcb2) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #21      +/-   ##
===========================================
- Coverage    96.99%   96.93%   -0.07%     
===========================================
  Files           32       32              
  Lines          599      587      -12     
  Branches       104      101       -3     
===========================================
- Hits           581      569      -12     
  Misses          10       10              
  Partials         8        8              
Files Changed Coverage Δ
etl_entities/hwm/column_hwm.py 89.47% <ø> (ø)
etl_entities/hwm/date_hwm.py 100.00% <ø> (ø)
etl_entities/hwm/datetime_hwm.py 100.00% <ø> (ø)
etl_entities/hwm/int_hwm.py 100.00% <ø> (ø)
etl_entities/source/db/table.py 100.00% <100.00%> (ø)

@dolfinus dolfinus merged commit 8655e59 into develop Sep 4, 2023
13 checks passed
@dolfinus dolfinus deleted the bugfix/DOP-8511 branch September 4, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants