Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9720] - add FileListHWM, FileHWM #30

Merged
merged 8 commits into from
Oct 23, 2023
Merged

[DOP-9720] - add FileListHWM, FileHWM #30

merged 8 commits into from
Oct 23, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Oct 20, 2023

Change Summary

  • Add classes: FileListHWM, FileHWM in etl_entitites.hwm
  • Add tests
  • Update documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #30 (964c6ee) into develop (baafda7) will decrease coverage by 0.08%.
The diff coverage is 95.60%.

@@             Coverage Diff             @@
##           develop      #30      +/-   ##
===========================================
- Coverage    96.19%   96.11%   -0.08%     
===========================================
  Files           38       40       +2     
  Lines          735      823      +88     
  Branches       122      137      +15     
===========================================
+ Hits           707      791      +84     
- Misses          14       16       +2     
- Partials        14       16       +2     
Files Coverage Δ
etl_entities/entity.py 96.42% <100.00%> (ø)
etl_entities/hwm/__init__.py 100.00% <100.00%> (ø)
etl_entities/hwm/hwm.py 90.00% <100.00%> (ø)
etl_entities/old_hwm/file_hwm.py 89.65% <ø> (ø)
etl_entities/hwm/file/file_hwm.py 92.30% <92.30%> (ø)
etl_entities/hwm/file/file_list_hwm.py 96.66% <96.66%> (ø)

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 20, 2023 11:55 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov marked this pull request as ready for review October 20, 2023 12:01
@maxim-lixakov maxim-lixakov self-assigned this Oct 20, 2023
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 08:39 — with GitHub Actions Inactive
@dolfinus
Copy link
Member

Добавь тесты на сериализацию/десериализацию.

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 11:55 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 12:11 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 12:45 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 12:51 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 23, 2023 12:56 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit 0ea67c9 into develop Oct 23, 2023
13 of 14 checks passed
@dolfinus dolfinus deleted the feature/DOP-9720 branch October 23, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants