Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-10395] - add detect_hwm_store decorator #33

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

maxim-lixakov
Copy link
Contributor

Change Summary

  • add decorator: detect_hwm_store in etl_entities.hwm_store (source code was imported from onetl.hwm.store)
  • add tests
  • update documentation

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov self-assigned this Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #33 (23afec3) into develop (24cdfcf) will increase coverage by 0.60%.
The diff coverage is 98.41%.

@@             Coverage Diff             @@
##           develop      #33      +/-   ##
===========================================
+ Coverage    94.78%   95.38%   +0.60%     
===========================================
  Files           47       48       +1     
  Lines          978     1041      +63     
  Branches       158      173      +15     
===========================================
+ Hits           927      993      +66     
+ Misses          30       27       -3     
  Partials        21       21              
Files Coverage Δ
etl_entities/entity.py 96.55% <100.00%> (+0.12%) ⬆️
etl_entities/hwm_store/__init__.py 100.00% <100.00%> (ø)
etl_entities/hwm_store/hwm_store_detect.py 98.36% <98.36%> (ø)

... and 1 file with indirect coverage changes

@maxim-lixakov maxim-lixakov marked this pull request as ready for review October 27, 2023 13:47
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 27, 2023 15:17 — with GitHub Actions Inactive
@dolfinus
Copy link
Member

dolfinus commented Oct 27, 2023

Поменяй в codecov.yml процент покрытия на 94. А то проверка будет постоянно падать

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 27, 2023 17:03 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 30, 2023 14:02 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 30, 2023 14:06 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 30, 2023 14:53 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 30, 2023 14:59 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 30, 2023 15:10 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 08:40 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 08:47 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 08:52 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 09:02 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 09:08 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 09:24 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 10:56 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi October 31, 2023 11:33 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov merged commit 5ed4274 into develop Oct 31, 2023
14 checks passed
@maxim-lixakov maxim-lixakov deleted the feature/DOP-10395 branch October 31, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants