Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update base_hwm_store config #38

Merged
merged 1 commit into from Nov 1, 2023
Merged

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Nov 1, 2023

Change Summary

  • restrict extra fields in BaseHWMStore and allow in BaseModel as classes Table, Process are inherited from BaseModel (as we keep compatibility)

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Nov 1, 2023
@maxim-lixakov maxim-lixakov self-assigned this Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #38 (1d109ee) into develop (f9a4435) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop      #38   +/-   ##
========================================
  Coverage    95.38%   95.39%           
========================================
  Files           48       48           
  Lines         1041     1042    +1     
  Branches       173      173           
========================================
+ Hits           993      994    +1     
  Misses          27       27           
  Partials        21       21           
Files Coverage Δ
etl_entities/entity.py 96.42% <ø> (-0.13%) ⬇️
etl_entities/hwm_store/memory_hwm_store.py 94.11% <100.00%> (+0.78%) ⬆️

@maxim-lixakov maxim-lixakov temporarily deployed to test-pypi November 1, 2023 14:49 — with GitHub Actions Inactive
@maxim-lixakov maxim-lixakov merged commit 9d513a7 into develop Nov 1, 2023
14 checks passed
@maxim-lixakov maxim-lixakov deleted the bugfix/update_base_hwm_store branch November 1, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants