Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add register_hwm_type to old_hwm classes #46

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Nov 7, 2023

Change Summary

  • Add @register_hwm_type decorator to old_hwm classes to keep compatibility with use of hwm_type from onetl library
  • update tests

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov added the ci:skip-changelog Add this label to skip changelog file check label Nov 7, 2023
@maxim-lixakov maxim-lixakov self-assigned this Nov 7, 2023
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #46 (00b096d) into develop (ab64f8e) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #46      +/-   ##
===========================================
+ Coverage    95.40%   95.43%   +0.03%     
===========================================
  Files           48       48              
  Lines         1045     1052       +7     
  Branches       174      178       +4     
===========================================
+ Hits           997     1004       +7     
  Misses          27       27              
  Partials        21       21              
Files Coverage Δ
etl_entities/old_hwm/date_hwm.py 100.00% <100.00%> (ø)
etl_entities/old_hwm/datetime_hwm.py 100.00% <100.00%> (ø)
etl_entities/old_hwm/file_list_hwm.py 97.18% <100.00%> (+0.08%) ⬆️
etl_entities/old_hwm/hwm.py 100.00% <100.00%> (ø)
etl_entities/old_hwm/int_hwm.py 100.00% <100.00%> (ø)

@maxim-lixakov maxim-lixakov merged commit cf8f892 into develop Nov 7, 2023
14 of 15 checks passed
@maxim-lixakov maxim-lixakov deleted the bugfix/update_old_hwm_type branch November 7, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants