Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ColumnIntHWM #49

Merged
merged 1 commit into from
Nov 13, 2023
Merged

update ColumnIntHWM #49

merged 1 commit into from
Nov 13, 2023

Conversation

maxim-lixakov
Copy link
Contributor

@maxim-lixakov maxim-lixakov commented Nov 13, 2023

Change Summary

  • Change value type in ColumnIntHWM from StrictInt to int, validation for float values

will be added separately

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@maxim-lixakov maxim-lixakov changed the title update ColumnIngHWM update ColumnIntHWM Nov 13, 2023
@maxim-lixakov maxim-lixakov self-assigned this Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #49 (5da8403) into develop (f4901df) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
- Coverage    95.43%   95.43%   -0.01%     
===========================================
  Files           48       48              
  Lines         1052     1051       -1     
  Branches       178      178              
===========================================
- Hits          1004     1003       -1     
  Misses          27       27              
  Partials        21       21              
Files Coverage Δ
etl_entities/hwm/column/int_hwm.py 100.00% <100.00%> (ø)

@dolfinus dolfinus merged commit 9f7f520 into develop Nov 13, 2023
14 checks passed
@dolfinus dolfinus deleted the feature/update_column_int_hwm branch November 13, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants